Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(base): disable ntp installed on noble #386

Merged
merged 7 commits into from
Jul 17, 2024
Merged

fix(base): disable ntp installed on noble #386

merged 7 commits into from
Jul 17, 2024

Conversation

JacobCoffee
Copy link
Member

What

  • Does not install ntp on noble as it uses timesyncd as an ntp client and running highstate in production causes conflicts

@JacobCoffee JacobCoffee requested a review from ewdurbin as a code owner July 16, 2024 19:18
@JacobCoffee
Copy link
Member Author

Confusion on why this doesnt affect local

Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the reason that this did not occur locally is that we don't install/start systemd-timesyncd which conflicts with ntp.

This must be coming from the DigitalOcean base images for 24.04, but we can account for it in our states still, if we were to move to another provider we want to ensure that we're using some form of time synchronization daemon!

salt/base/sanity.sls Outdated Show resolved Hide resolved
@JacobCoffee JacobCoffee requested a review from ewdurbin July 16, 2024 21:26
salt/base/sanity.sls Outdated Show resolved Hide resolved
Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further down the rabbit hole, it seems systemd-timesyncd refuses to run in a container, which is actually kinda cool but shows the limits of our local dev setup 🙃

I opened #387 which should give us a way to bail out of functionality that doesn't work in a docker container via a grain, might be helpful in pushing this along.

salt/base/sanity.sls Show resolved Hide resolved
@JacobCoffee JacobCoffee requested a review from ewdurbin July 17, 2024 14:07
@JacobCoffee JacobCoffee merged commit a01b900 into main Jul 17, 2024
2 checks passed
@JacobCoffee JacobCoffee deleted the ntp-noble branch July 17, 2024 15:28
Copy link
Contributor

Don't forget to pull the latest changes on salt.nyc1.psf.io!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants